fix: Claude Desktop 官方供应商添加报错 #3402 (#3405)

* fix: Claude Desktop 官方供应商添加时缺少 ANTHROPIC_BASE_URL 报错根因：前端 mutation 为 claude-desktop 生成随机 UUID 作为 provider id，后端 is_official_provider 通过 id 匹配跳过校验，随机 UUID 不匹配导致走入普通 direct 模式校验并要求 ANTHROPIC_BASE_URL。修复： - 前端：claude-desktop + category=official 时使用固定 id "claude-desktop-official" - 后端：validate_provider / validate_direct_provider / validate_proxy_provider / apply_provider_to_paths 增加 category=="official" 兜底检查 Fixes #3402 * fix: restrict Claude Desktop official provider detection * fix: add Claude Desktop official provider via seed --------- Co-authored-by: 金恩光 <enguang.jin@gmail.com> Co-authored-by: Jason <farion1231@gmail.com>
2026-08-02 10:21:16 +08:00 · 2026-05-31 23:37:31 +08:00
parent 5ef72a2030
commit 0960fd7179
8 changed files with 185 additions and 3 deletions
@@ -0,0 +1,136 @@
+import type { ReactNode } from "react";
+import { act, renderHook } from "@testing-library/react";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { useAddProviderMutation } from "@/lib/query/mutations";
+import type { Provider } from "@/types";
+
+const apiMocks = vi.hoisted(() => ({
+  add: vi.fn(),
+  ensureClaudeDesktopOfficialProvider: vi.fn(),
+  getAll: vi.fn(),
+  updateTrayMenu: vi.fn(),
+}));
+
+const uuidMocks = vi.hoisted(() => ({
+  generateUUID: vi.fn(),
+}));
+
+vi.mock("@/lib/api", () => ({
+  providersApi: {
+    add: (...args: unknown[]) => apiMocks.add(...args),
+    ensureClaudeDesktopOfficialProvider: (...args: unknown[]) =>
+      apiMocks.ensureClaudeDesktopOfficialProvider(...args),
+    getAll: (...args: unknown[]) => apiMocks.getAll(...args),
+    updateTrayMenu: (...args: unknown[]) => apiMocks.updateTrayMenu(...args),
+  },
+  sessionsApi: {},
+  settingsApi: {},
+}));
+
+vi.mock("@/utils/uuid", () => ({
+  generateUUID: () => uuidMocks.generateUUID(),
+}));
+
+vi.mock("sonner", () => ({
+  toast: {
+    success: vi.fn(),
+    error: vi.fn(),
+  },
+}));
+
+function createWrapper() {
+  const queryClient = new QueryClient({
+    defaultOptions: {
+      queries: { retry: false },
+      mutations: { retry: false },
+    },
+  });
+
+  const wrapper = ({ children }: { children: ReactNode }) => (
+    <QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
+  );
+
+  return { wrapper };
+}
+
+beforeEach(() => {
+  apiMocks.add.mockReset().mockResolvedValue(true);
+  apiMocks.ensureClaudeDesktopOfficialProvider
+    .mockReset()
+    .mockResolvedValue(true);
+  apiMocks.getAll.mockReset().mockResolvedValue({});
+  apiMocks.updateTrayMenu.mockReset().mockResolvedValue(true);
+  uuidMocks.generateUUID.mockReset().mockReturnValue("generated-uuid");
+});
+
+describe("useAddProviderMutation", () => {
+  it("duplicates Claude Desktop official providers with a fresh id", async () => {
+    const { wrapper } = createWrapper();
+    const { result } = renderHook(
+      () => useAddProviderMutation("claude-desktop"),
+      { wrapper },
+    );
+
+    const duplicatedProvider = await act(async () =>
+      result.current.mutateAsync({
+        name: "Claude Desktop Official copy",
+        settingsConfig: { env: {} },
+        category: "official",
+      }),
+    );
+
+    expect(apiMocks.ensureClaudeDesktopOfficialProvider).not.toHaveBeenCalled();
+    expect(apiMocks.add).toHaveBeenCalledTimes(1);
+    expect(apiMocks.add).toHaveBeenCalledWith(
+      expect.objectContaining({
+        id: "generated-uuid",
+        name: "Claude Desktop Official copy",
+        category: "official",
+      }),
+      "claude-desktop",
+      undefined,
+    );
+    expect(duplicatedProvider.id).toBe("generated-uuid");
+    expect(duplicatedProvider.id).not.toBe("claude-desktop-official");
+  });
+
+  it("returns the persisted seed row for the Claude Desktop official preset", async () => {
+    const seedProvider: Provider = {
+      id: "claude-desktop-official",
+      name: "Claude Desktop Official",
+      settingsConfig: { env: {} },
+      websiteUrl: "https://claude.ai/download",
+      category: "official",
+      icon: "anthropic",
+      iconColor: "#D4915D",
+      createdAt: 123,
+    };
+    apiMocks.getAll.mockResolvedValueOnce({
+      "claude-desktop-official": seedProvider,
+    });
+    const { wrapper } = createWrapper();
+    const { result } = renderHook(
+      () => useAddProviderMutation("claude-desktop"),
+      { wrapper },
+    );
+
+    const persistedProvider = await act(async () =>
+      result.current.mutateAsync({
+        name: "Renamed by form",
+        settingsConfig: { env: { ignored: true } },
+        websiteUrl: "https://example.invalid",
+        category: "official",
+        icon: "custom-icon",
+        ensureClaudeDesktopOfficialSeed: true,
+      }),
+    );
+
+    expect(apiMocks.ensureClaudeDesktopOfficialProvider).toHaveBeenCalledTimes(
+      1,
+    );
+    expect(apiMocks.getAll).toHaveBeenCalledWith("claude-desktop");
+    expect(apiMocks.add).not.toHaveBeenCalled();
+    expect(persistedProvider).toEqual(seedProvider);
+  });
+});