fix(usage): dedupe Claude Desktop proxy and session logs (#5951)

This commit is contained in:
Komi
2026-07-31 15:00:18 +08:00
committed by GitHub
parent c49cf96a16
commit 4bfb3fc30d
5 changed files with 164 additions and 6 deletions
+51
View File
@@ -687,6 +687,57 @@ mod tests {
Ok(())
}
#[test]
fn claude_desktop_proxy_replaces_matching_session_log_row() -> Result<(), AppError> {
let db = Database::memory()?;
{
let conn = crate::database::lock_conn!(db.conn);
conn.execute(
"INSERT INTO proxy_request_logs (
request_id, provider_id, app_type, model, input_tokens,
output_tokens, cache_read_tokens, cache_creation_tokens,
latency_ms, status_code, created_at, data_source
) VALUES ('session:msg_desktop', '_session', 'claude',
'claude-sonnet-4-5', 10, 5, 2, 1, 0, 200, 1, 'session_log')",
[],
)?;
}
let usage = TokenUsage {
input_tokens: 10,
output_tokens: 5,
cache_read_tokens: 2,
cache_creation_tokens: 1,
model: Some("claude-sonnet-4-5".to_string()),
message_id: Some("msg_desktop".to_string()),
};
let request_id = usage.dedup_request_id(crate::proxy::usage::parser::dedup_scope_for_app(
"claude-desktop",
"desktop-provider",
));
let mut proxy_log = request_log(&request_id, 10);
proxy_log.provider_id = "desktop-provider".to_string();
proxy_log.app_type = "claude-desktop".to_string();
proxy_log.model = "claude-sonnet-4-5".to_string();
proxy_log.request_model = "claude-sonnet-4-5".to_string();
proxy_log.pricing_model = "claude-sonnet-4-5".to_string();
proxy_log.usage = usage;
UsageLogger::new(&db).log_request(&proxy_log)?;
let conn = crate::database::lock_conn!(db.conn);
let (count, source, app_type): (i64, String, String) = conn.query_row(
"SELECT COUNT(*), data_source, app_type FROM proxy_request_logs
WHERE request_id = 'session:msg_desktop'",
[],
|row| Ok((row.get(0)?, row.get(1)?, row.get(2)?)),
)?;
assert_eq!(count, 1);
assert_eq!(source, "proxy");
assert_eq!(app_type, "claude-desktop");
Ok(())
}
#[test]
fn test_log_error() -> Result<(), AppError> {
let db = Database::memory()?;
+29
View File
@@ -30,6 +30,16 @@ fn openai_cache_write_tokens(usage: &Value) -> u32 {
/// Session 日志 request_id 前缀,与 `session_usage.rs` 中的格式保持一致
pub const SESSION_REQUEST_ID_PREFIX: &str = "session:";
/// Claude Code and Claude Desktop share Claude message ids with the session
/// importer, so both use the bare `session:{message_id}` namespace. Other
/// apps retain app/provider scoping to avoid collisions between upstreams.
pub fn dedup_scope_for_app<'a>(
app_type: &'a str,
provider_id: &'a str,
) -> Option<(&'a str, &'a str)> {
(!matches!(app_type, "claude" | "claude-desktop")).then_some((app_type, provider_id))
}
fn response_id(body: &Value, field: &str) -> Option<String> {
body.get(field)
.and_then(Value::as_str)
@@ -479,6 +489,25 @@ mod tests {
.starts_with("session:"));
}
#[test]
fn claude_apps_share_the_session_request_id_namespace() {
let usage = TokenUsage {
message_id: Some("msg_123".to_string()),
..Default::default()
};
for app_type in ["claude", "claude-desktop"] {
assert_eq!(
usage.dedup_request_id(dedup_scope_for_app(app_type, "provider-a")),
"session:msg_123"
);
}
assert_eq!(
usage.dedup_request_id(dedup_scope_for_app("codex", "provider-a")),
"session:codex:provider-a:msg_123"
);
}
#[test]
fn stream_parsers_recover_ids_from_envelope_chunks() {
let openai = vec![