admin/CC-Switch
1
0
Fork 0
mirror of https://github.com/farion1231/cc-switch.git synced 2026-07-24 12:44:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve WebDAV password display and validate MKCOL 405 (#1685)

Browse Source 
* fix: preserve WebDAV password display and validate MKCOL 405

* fix: scope WebDAV password preservation to post-save refresh
This commit is contained in:
Alexlangl
2026-03-30 22:13:21 +08:00
committed by GitHub
parent 67e074c0a7
commit 4f7ea76347
3 changed files with 171 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/components/WebdavSyncSection.test.tsx
+108 -2
View File
@@ -104,11 +104,12 @@ function renderSection(config?: WebDavSyncSettings) {
mutations: { retry: false },
},
});
return render(
const view = render(
<QueryClientProvider client={client}>
<WebdavSyncSection config={config} />
</QueryClientProvider>,
);
return { ...view, client };
}
describe("WebdavSyncSection", () => {
@@ -204,7 +205,7 @@ describe("WebdavSyncSection", () => {
expect.objectContaining({
baseUrl: "https://dav.example.com/dav/",
username: "alice",
password: "secret",
password: "",
autoSync: false,
}),
false,
@@ -222,6 +223,111 @@ describe("WebdavSyncSection", () => {
);
});
it("preserves password only for the single post-save refresh", async () => {
const view = renderSection(baseConfig);
fireEvent.click(screen.getByRole("button", { name: "settings.webdavSync.save" }));
await waitFor(() => {
expect(settingsApiMock.webdavSyncSaveSettings).toHaveBeenCalledTimes(1);
});
view.rerender(
<QueryClientProvider client={view.client}>
<WebdavSyncSection config={{ ...baseConfig, password: "" }} />
</QueryClientProvider>,
);
expect(
(
screen.getByPlaceholderText(
"settings.webdavSync.passwordPlaceholder",
) as HTMLInputElement
).value,
).toBe("secret");
view.rerender(
<QueryClientProvider client={view.client}>
<WebdavSyncSection config={{ ...baseConfig, password: "" }} />
</QueryClientProvider>,
);
expect(
(
screen.getByPlaceholderText(
"settings.webdavSync.passwordPlaceholder",
) as HTMLInputElement
).value,
).toBe("");
});
it("does not preserve password after a later external config refresh", async () => {
const view = renderSection(baseConfig);
fireEvent.click(screen.getByRole("button", { name: "settings.webdavSync.save" }));
await waitFor(() => {
expect(settingsApiMock.webdavSyncSaveSettings).toHaveBeenCalledTimes(1);
});
view.rerender(
<QueryClientProvider client={view.client}>
<WebdavSyncSection config={{ ...baseConfig, password: "" }} />
</QueryClientProvider>,
);
expect(
(
screen.getByPlaceholderText(
"settings.webdavSync.passwordPlaceholder",
) as HTMLInputElement
).value,
).toBe("secret");
view.rerender(
<QueryClientProvider client={view.client}>
<WebdavSyncSection
config={{ ...baseConfig, username: "bob", password: "" }}
/>
</QueryClientProvider>,
);
expect(
(
screen.getByPlaceholderText(
"settings.webdavSync.passwordPlaceholder",
) as HTMLInputElement
).value,
).toBe("");
});
it("does not submit a preserved password again when testing without touching it", async () => {
const view = renderSection(baseConfig);
fireEvent.click(screen.getByRole("button", { name: "settings.webdavSync.save" }));
await waitFor(() => {
expect(settingsApiMock.webdavSyncSaveSettings).toHaveBeenCalledTimes(1);
});
view.rerender(
<QueryClientProvider client={view.client}>
<WebdavSyncSection config={{ ...baseConfig, password: "" }} />
</QueryClientProvider>,
);
fireEvent.click(screen.getByRole("button", { name: "settings.webdavSync.test" }));
await waitFor(() => {
expect(settingsApiMock.webdavTestConnection).toHaveBeenLastCalledWith(
expect.objectContaining({
password: "",
}),
true,
);
});
});
it("saves auto sync as true after toggle", async () => {
renderSection(baseConfig);